Fix additional Python and JupyterLab edge case - #182
Merged
Samruddhi Khandale (samruddhikhandale) merged 7 commits intoSep 26, 2022
Merged
Fix additional Python and JupyterLab edge case#182Samruddhi Khandale (samruddhikhandale) merged 7 commits into
Samruddhi Khandale (samruddhikhandale) merged 7 commits into
Conversation
Samruddhi Khandale (samruddhikhandale)
previously approved these changes
Sep 26, 2022
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
LGTM ✨
Can we make the image path change before merging this PR?
Samruddhi Khandale (samruddhikhandale)
previously approved these changes
Sep 26, 2022
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Thanks!
Samruddhi Khandale (samruddhikhandale)
approved these changes
Sep 26, 2022
Samruddhi Khandale (samruddhikhandale)
deleted the
jungaretti/misplaced-jupyterlab
branch
September 26, 2022 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: devcontainers/images#125
Fixes an edge case in the Python feature that installs JupyterLab to the
additionalVersionsof Python instead of the primaryversionof Python.This PR also removes junk from our JupyterLab test and adds a new test that would have caught this bug.
Edge Case Details
install_user_packageinstalls packages to whatever Python installation is specified by$INSTALL_PATH. Bothinstall_from_sourceandinstall_using_oryxoverwrite this variable. When we useinstall_pythonto install an extra version of Python, we overwrite$INSTALL_PATHto that installation.When we install JupyterLab at the end of the script, it uses the
$INSTALL_PATHset by the most recentadditionalVersionsinstead ofversion.My fix saves
$INSTALL_PATHbefore installing additional versions and restores it afterwards.